[awattar] Fix that allows bridge to be added via UI. #13730
Conversation
Signed-off-by: Doug Culnane <doug@culnane.net>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/awattar-binding-beta-and-discussion/110497/71 |
| @@ -1,14 +0,0 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <thing:thing-descriptions bindingId="openweathermap" | |||
There was a problem hiding this comment.
The reason it didn't work is that the bindingId is wrong in this file
There was a problem hiding this comment.
@Hilbrand OK. That is the real problem then. My fix was more of a work around that worked.
What is better, my fix or changing the bindingId?
There was a problem hiding this comment.
In general there is no best choice. Either solution is ok. In this case it probably makes more sense to have everything in one file as it's only a small set of things. I would say your fix is ok.
There was a problem hiding this comment.
Sorry for the copy-paste error, was my bad :-(
There was a problem hiding this comment.
@Wolfgang1966 no problem it gave me an easy fix (work around).
|
LGTM |
Signed-off-by: Doug Culnane <doug@culnane.net> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Signed-off-by: Doug Culnane <doug@culnane.net> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Signed-off-by: Doug Culnane <doug@culnane.net>
Signed-off-by: Doug Culnane <doug@culnane.net>
Signed-off-by: Doug Culnane <doug@culnane.net>
Signed-off-by: Doug Culnane <doug@culnane.net> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
As per discussion in the forum: https://community.openhab.org/t/awattar-binding-beta-and-discussion/110497/70
the awatar bridge can not be added as a thing with the UI 3. This fixes (or works around) the problem.
Signed-off-by: Doug Culnane doug@culnane.net